D24815: [Weather] Make update time spinbox editable

2019-10-21 Thread Nathaniel Graham
ngraham added a comment. Landing without approval since D24816 which does the exact same thing elsewhere was approved, and the logic for approving is identical. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24815 To:

D24815: [Weather] Make update time spinbox editable

2019-10-21 Thread Nathaniel Graham
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:ec2392dbf70a: [Weather] Make update time spinbox editable (authored by ngraham). REPOSITORY R114 Plasma Addons CHAN

D24815: [Weather] Make update time spinbox editable

2019-10-21 Thread Nathaniel Graham
ngraham updated this revision to Diff 68462. ngraham added a comment. Add a valueFromText handler REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24815?vs=68398&id=68462 BRANCH editable-spinbox (branched from Plasma/5.17) REVISION DETAIL https://

D24815: [Weather] Make update time spinbox editable

2019-10-20 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN Now you can enter text in it using the keyboard. To make this more predictible, the custom stepSiz