D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > meven wrote in main.qml:30 > PlasmNM.Handler must be kept, (used line 56) oops, fixed REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulich Cc: plasma-deve

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Méven Car
meven added inline comments. INLINE COMMENTS > main.qml:30 > > -PlasmaNM.Handler { > -id: handler PlasmNM.Handler must be kept, (used line 56) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulic

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Nicolas Fella
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:fefb9ef507ef: Fix regression in mobile wifi kcm (authored by nicolasfella). REPOSITORY R116 Plasma Network Managemen

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Méven Car
meven accepted this revision. meven added a comment. I wish I had caught this, thanks @nicolasfella REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24804 To: nicolasfella, meven, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleig

D24804: Fix regression in mobile wifi kcm

2019-10-20 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY D23578 remov