This revision was automatically updated to reflect the committed changes.
Closed by commit R124:de7f988c71b2: Store stashed model index as
QPersistentModelIndex (authored by davidedmundson).
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24785?vs=68307
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Makes a lot of sense.
REPOSITORY
R124 System Settings
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24785
To: davidedmundson, #plasma, apol
Cc: apol, plasma-devel, LeGast00
davidedmundson added a comment.
Thread 1 (Thread 0x7f17b0836400 (LWP 5535)):
[KCrash Handler]
#6 KService::d_func (this=0x0) at
/home/david/projects/kde5/src/frameworks/kservice/src/services/kservice.h:587
#7 0x7f17b677e3c3 in KService::comment (this=0x0) at
/home/david/projects/k
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Otherwise we can crash if the model updates during load.
TEST PLAN
Had a s
