D24750: Fix reading environment variables with newline

2019-10-18 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R120:595ab88bc2ee: Fix reading environment variables with newline (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24750?vs=68217&id=68233 R

D24750: Fix reading environment variables with newline

2019-10-18 Thread Adriaan de Groot
adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. Looked for -0 alternatives, couldn't find any. Dave tells me there's sufficient fallbacks, and otherwise we'll just patch it out in packaging. REPOSITORY R120 Plasma Workspace BRANCH P

D24750: Fix reading environment variables with newline

2019-10-18 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks for the swift action REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde.org/D24750 To: fvogt, #plasma, apol, davidedm

D24750: Fix reading environment variables with newline

2019-10-18 Thread Fabian Vogt
fvogt added a comment. Note, the "-0" option is only available in GNU env, not in BSD /env... I can't think of a better way to fix this though other than implementing env ourselves in native code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24750 To: f

D24750: Fix reading environment variables with newline

2019-10-18 Thread Fabian Vogt
fvogt updated this revision to Diff 68217. fvogt added a comment. arc is a PoS REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24750?vs=68216&id=68217 BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde.org/D24750 AFFECTED FILES star

D24750: Fix reading environment variables with newline

2019-10-18 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, apol. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Use '\0' as separator as '\n' is likely to appear in values. BUG: 413130 TEST PLAN /etc/profile.d/mc.sh exported an mc() function,