D24732: Rewrite AppChooser dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R838:c85055441a22: Rewrite AppChooser dialog (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68673&id

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#552239 , @ngraham wrote: > There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle. Solve

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68673. jgrulich added a comment. - Add border around the view and use small radius around for item highlight REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68502&id=68673 B

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#552239 , @ngraham wrote: > There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle. Right

D24732: Rewrite AppChooser dialog

ngraham added a reviewer: VDG. ngraham added a comment. There still isn't a border around the inner view. That's what I'm trying to get there. Otherwise it doesn't look like an inner view; it looks like a floating rectangle. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVI

D24732: Rewrite AppChooser dialog

jgrulich added a comment. Updated screenshot: F7649124: Screenshot_20191022_161043.png To be honest, I liked the result more when the "view" wasn't using a different background. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVIS

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68502. jgrulich added a comment. - Add Kirigami2 as a dependency REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68501&id=68502 BRANCH new-app-dialog REVISION DETAIL ht

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68501. jgrulich added a comment. - Code improvements REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68382&id=68501 BRANCH new-app-dialog REVISION DETAIL https://phabri

D24732: Rewrite AppChooser dialog

ngraham added a subscriber: mart. ngraham added a comment. In D24732#551035 , @jgrulich wrote: > In D24732#550902 , @ngraham wrote: > > > So close! You don't need to create a `Rectangle` to give the

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#550902 , @ngraham wrote: > So close! You don't need to create a `Rectangle` to give the ScrollView a white background; just set `Component.onCompleted: background.visible = true` on the scrollview itself. Here

D24732: Rewrite AppChooser dialog

ngraham added a comment. So close! You don't need to create a `Rectangle` to give the ScrollView a white background; just set `Component.onCompleted: background.visible = true` on the scrollview itself. Here's an example of how it's done in the Notifications KCM: https://cgit.kde.org/plasma

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68382. jgrulich added a comment. - Improvements based on review comments REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68218&id=68382 BRANCH new-app-dialog REVISION DET

D24732: Rewrite AppChooser dialog

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Aha, the old one was indeed still running! I can see the new one now. - My request to give the scrollview a frame and the background isn't implemented yet. - My request to

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#549750 , @ngraham wrote: > On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried overriding that file with the one I just built from source (because it didn't seem to use the built-from-so

D24732: Rewrite AppChooser dialog

ngraham added a comment. On my system, it's at `/usr/lib64/libexec/xdg-desktop-portal-kde`. I tried overriding that file with the one I just built from source (because it didn't seem to use the built-from-source one at `~/kde/usr/lib64/libexec/xdg-desktop-portal-kde`) but even then, I still

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#549249 , @ngraham wrote: > Finally, I would consider adding the "Other applications are available in Discover" text to the bottom, so it doesn't interrupt the dialog's flow. I'm not sure about that, bec

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68218. jgrulich added a comment. Address review comments REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68140&id=68218 BRANCH new-app-dialog REVISION DETAIL https://ph

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#549249 , @ngraham wrote: > Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller: F7616694: Screenshot_20191017_111833.png

D24732: Rewrite AppChooser dialog

ngraham added a comment. Give the scrollview a frame and a white background or else apps look cut off and weird and there's a mysteriously hovering scroller: F7616694: Screenshot_20191017_111833.png Also why are there duplicates in here? Finall

D24732: Rewrite AppChooser dialog

GB_2 added inline comments. INLINE COMMENTS > AppChooserDialog.qml:47 > +horizontalAlignment: Text.AlignHCenter > +text: i18n("Select application to open %1. Other applications > are available in Discover.", fileName) > +textFormat: Text.RichText "Select an application t

D24732: Rewrite AppChooser dialog

jgrulich added a comment. Use Dolphin from Flathub to open some file. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbam

D24732: Rewrite AppChooser dialog

ngraham added a comment. What's the best way to test this out? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ngraham, apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouka

D24732: Rewrite AppChooser dialog

apol added a comment. +1 looks much better REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: apol, ognarb, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ng

D24732: Rewrite AppChooser dialog

jgrulich added a comment. Is this better? F7615448: Screenshot_20191017_155608.png REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ognarb, plasma-devel, L

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68140. jgrulich added a comment. Add text to the button rather then using tooltip REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68137&id=68140 BRANCH new-app-dialog REV

D24732: Rewrite AppChooser dialog

jgrulich added a comment. In D24732#548992 , @ognarb wrote: > I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps There is a tooltip, but maybe showing text next to it might be bett

D24732: Rewrite AppChooser dialog

ognarb added a comment. I would add text on the button e.g "Show more", otherwise it's quite difficult to know how to show more apps REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D24732 To: jgrulich, #plasma Cc: ognarb, plasma-de

D24732: Rewrite AppChooser dialog

jgrulich added a comment. This is the initial state of the dialog, which presents only apps associated with given mimetype. Then if you click at the button below, it will show all the apps and provide a search bar. F7615342: Screenshot_20191017_154506.png

D24732: Rewrite AppChooser dialog

jgrulich updated this revision to Diff 68137. jgrulich added a comment. Do not duplicate desktop files REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24732?vs=68134&id=68137 BRANCH new-app-dialog REVISION DETAIL htt

D24732: Rewrite AppChooser dialog

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY The new version of dialog allows you to select any application if associated applications are not what users want. The dialog