This revision was automatically updated to reflect the committed changes.
Closed by commit R116:82e187663135: Add support for WPA3 (authored by jgrulich).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D24691?vs=68155&id=70330#toc
REPOSITORY
R116 Plasma Network Management Applet
CHANGES
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Nice, I am properly not the best reviewer here, but it looks ok to me.
INLINE COMMENTS
> wifisecurity.cpp:118
> +} else if (securityIndex == SAE) {
> +return !m_ui->psk->text().is
jgrulich added a comment.
Ping?
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D24691
To: jgrulich, #plasma
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, l
jgrulich updated this revision to Diff 68155.
jgrulich added a comment.
Simplify code
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24691?vs=68036&id=68155
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24691
AFFEC
meven added inline comments.
INLINE COMMENTS
> wifisecurity.cpp:403
> {
> -if (index == 0) {
> +if (index == 0) { // None
> m_ui->stackedWidget->setCurrentIndex(0);
It would be nice to convert use SecurityTypeIndex enum instead of hardcoded
values.
It seems to me those values
jgrulich updated this revision to Diff 68036.
jgrulich added a comment.
Drop cmake change
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24691?vs=68035&id=68036
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24691
A
jgrulich created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
jgrulich requested review of this revision.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24691
AFFECTED FILES
CMakeLists.
