D24615: Fix crash with sortAllByName/Description

2019-10-14 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R103:3d4640bea622: Fix crash with sortAllByName/Description (authored by ahmadsamir). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24615?vs=67855&id=67891 REVISI

D24615: Fix crash with sortAllByName/Description

2019-10-13 Thread Laurent Montel
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. it seems ok for me. Thanks REPOSITORY R103 KMenu Editor BRANCH ahmad/takechildren-crash-on-index-rootItem (branched from master) REVISION DETAIL https://phabricator.kde.org/D24

D24615: Fix crash with sortAllByName/Description

2019-10-13 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahmadsamir requested review of this revision. REVISION SUMMARY Calling QTreeWidgetItem::takeChildren() on invisibleRootItem() results in a crash bec