This revision was automatically updated to reflect the committed changes.
Closed by commit R119:bb2b300addfb: Expose the settings object to QML (authored
by ervin).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24394?vs=67303&id=67308
REVISION DETAIL
ervin updated this revision to Diff 67303.
ervin added a comment.
Add missing copyright header change
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24394?vs=67270&id=67303
REVISION DETAIL
https://phabricator.kde.org/D24394
AFFECTED FILES
kcms/
ervin added inline comments.
INLINE COMMENTS
> mart wrote in kcm.h:47
> generic api musings:
> could this be upstreamed into ConfigModule directly? (since can't be a
> virtual, a protected setter?)
Yes, I got something like that in mind down the line. It's a bit early though,
I'd like to see f
ervin added a comment.
Yes, I got something like that in mind for future commits. I need to first
add a few things in KConfig though.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D24394
To: ervin, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,
mart added inline comments.
INLINE COMMENTS
> kcm.h:47
> Q_OBJECT
> +Q_PROPERTY(DesktopThemeSettings *desktopThemeSettings READ
> desktopThemeSettings CONSTANT)
> Q_PROPERTY(QStandardItemModel *desktopThemeModel READ desktopThemeModel
> CONSTANT)
generic api musings:
could this b
ervin created this revision.
ervin added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ervin requested review of this revision.
REVISION SUMMARY
This simplifies quite a bit the logic, we don't need to do the
bookkeeping ourselves anymore. Onl
