D24363: Fix several build system errors

This revision was automatically updated to reflect the committed changes. Closed by commit R858:731b85008c21: Fix several build system errors (authored by alexeymin). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24363?vs=67233&id=6

D24363: Fix several build system errors

alexeymin marked an inline comment as done. alexeymin added a comment. Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our main documentation page https://api.kde.org/frameworks/index.html . If it is really Tier 3, then maybe it does not even make sense to make IconThe

D24363: Fix several build system errors

alexeymin updated this revision to Diff 67233. alexeymin added a comment. - Bring back missing KF5_DEP_VERSION REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24363?vs=67207&id=67233 BRANCH alexeymin/fix-cmake-errors REVISION D

D24363: Fix several build system errors

cgiboudeaux added a comment. Note: the metainfo file says this framework is tier 3. The subgroup value looks wrong INLINE COMMENTS > CMakeLists.txt:40-41 > +# IconThemes and ConfigWidgets are optional > +find_package(KF5IconThemes) > +find_package(KF5ConfigWidgets) > KF5_DEP_VERSION i

D24363: Fix several build system errors

alexeymin reopened this revision. alexeymin added a comment. Phabricator, you're drunk, it is not pushed to master REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel, plasma-d

D24363: Fix several build system errors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:9ddd3ba2f531: qqc2-desktop-style: Fix several builsystem errors (authored by Aleksey Minnekhanov