This revision was automatically updated to reflect the committed changes.
Closed by commit R106:e358aa840a34: Fix a number of issues found by the
OpenSuse security team in networkhelper (authored by ahiemstra).
REPOSITORY
R106 KSysguard
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
maltek accepted this revision.
maltek added a comment.
This revision is now accepted and ready to land.
Looks good to me. Thanks for the quick reaction (and sorry for my slow one!)
> Which is a bit different, as it implies (to me) that the loop will still
exit the next time the thread is
ahiemstra added a comment.
Note that https://bugzilla.opensuse.org/show_bug.cgi?id=1152638 says
`pcap_breakloop()` is unsupported when called from multiple threads. However,
the actual libpcap documentation states:
> Note also that, in a multi-threaded application, if one thread is block
ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
See https://bugzilla.opensuse.org/show_bug.cgi?id=1151190 and its dependencies
for details
