D24165: Add SettingsUtil utility class

This revision was automatically updated to reflect the committed changes. Closed by commit R856:64d6bab15fe6: Add SettingsUtils utility class (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24165?vs=66690&id=66750 REVI

D24165: Add SettingsUtil utility class

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Appears to work on ESR REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24165 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, LeGast00n, The-

D24165: Add SettingsUtil utility class

ognarb added a comment. +1 but I couldn't test it (changed my distro recently and can't get pbi to work yet). The js class is available in firefox since Firefox 45 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes#Browser_compatibility so it should work in firefo

D24165: Add SettingsUtil utility class

broulik updated this revision to Diff 66690. broulik edited the summary of this revision. broulik added a comment. - Drop changed stuff for now - Catch exception directly in get and reject REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D24165: Add SettingsUtil utility class

broulik added a comment. In D24165#536531 , @fvogt wrote: > I can try if you'd like. That would be appreciated. INLINE COMMENTS > fvogt wrote in utils.js:19 > Wow, ES6 does indeed not support static members... Yeah... :/ > fvogt wrote

D24165: Add SettingsUtil utility class

fvogt added a comment. > Probably needs some Firefox ESR 60 testing to see whether it can deal with the class stuff... I can try if you'd like. INLINE COMMENTS > options.js:137 > }); > // When the extension is reloaded, any call to extension APIs throws > } catch (e)

D24165: Add SettingsUtil utility class

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For reading, writing, and eventually getting notified of changes to settings. Prom