D24127: Fix toggle button colours

ngraham added a comment. I think this patch needs some changes (outlined above). REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ra

D24127: Fix toggle button colours

ndavis added a comment. Friendly ping. It would be nice to have this in 5.17.1 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragr

D24127: Fix toggle button colours

ndavis added a comment. In D24127#536672 , @ngraham wrote: > @cblack if we're going to use this patch to do that, then the same treatment needs to be done for other buttonlike controls like comboboxes (with and without text entry), font buttons,

D24127: Fix toggle button colours

ngraham added a comment. @cblack if we're going to use this patch to do that, then the same treatment needs to be done for other buttonlike controls like comboboxes (with and without text entry), font buttons, file picker buttons, etc. Also I feel like maybe the border thickness of the highl

D24127: Fix toggle button colours

cblack updated this revision to Diff 66712. cblack added a comment. Substitute border decoration for fill decoration REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24127?vs=66574&id=66712 BRANCH fix-toggle-state (branched from master) REVISION DET

D24127: Fix toggle button colours

ndavis added a comment. In D24127#535826 , @cblack wrote: > In D24127#53 , @ndavis wrote: > > > @cblack Can you change the focus state to only have a blue outline? This behavior is really confusi

D24127: Fix toggle button colours

ngraham added a comment. Weird, this happens with the regular old breeze color scheme for me. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalouk

D24127: Fix toggle button colours

cblack added a comment. In D24127#535551 , @ngraham shared an image: > F7398590: Screenshot_20190920_194959.png That doesn't match the color of what I have on my machine. F7405543: image.png

D24127: Fix toggle button colours

cblack added a comment. In D24127#53 , @ndavis wrote: > @cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze: F7398663: gtk_togglebuttons-2019-09-2

D24127: Fix toggle button colours

ngraham added a comment. Yeah, it's definitely more obvious in Breeze dark, but I've always felt that a more colorful color was appropriate for the default button. Maybe it's just my history in macOS, where it's been like that for 20 years, but I've always appreciated being able to visually

D24127: Fix toggle button colours

ndavis added a comment. In D24127#535558 , @ngraham wrote: > In D24127#53 , @ndavis wrote: > > > This behavior is really confusing, even though it seems consistent with Breeze > > > I reall

D24127: Fix toggle button colours

ngraham added a comment. In D24127#53 , @ndavis wrote: > This behavior is really confusing, even though it seems consistent with Breeze I really dislike this about Breeze itself and would welcome a fix there too. Then maybe we can ma

D24127: Fix toggle button colours

ndavis added a comment. In the beginning of the video where it looks like I'm just hovering, I'm actually clicking once a second. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, T

D24127: Fix toggle button colours

ndavis added a comment. @cblack Can you change the focus state to only have a blue outline? This behavior is really confusing, even though it seems consistent with Breeze: F7398663: gtk_togglebuttons-2019-09-20_21.55.35.webm REPOSITORY R98 Breeze for

D24127: Fix toggle button colours

ndavis added a comment. Ah, I only tested Breeze Dark, which uses the same white text color for everything. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24127 To: cblack, #breeze, ndavis, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jrale

D24127: Fix toggle button colours

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I was actually just about to report this, hah. The text color for the checked state looks too light for Breeze and Breeze light though: F7398590: Screenshot_20190920_194959.png

D24127: Fix toggle button colours

cblack created this revision. cblack added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY Toggle button colors are now correct. REPOSITORY R98 Breeze for Gtk BRANCH fix-toggle-state (br