D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R124:e649d5a706b6: Improve keyboard navigation (authored by ognarb). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23975?vs=66154&id=66158 REVISION DETAIL ht

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb added a comment. Thanks, I will try to send a kirigami patch, if I don't send anything before the next weekend consider that I forgot ;p REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23975 To: ognarb, #plasma, #plasma_accessibility,

D23975: Improve keyboard navigation

2019-09-15 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All right, let's land this then, and fix it in Kirigami. Do you fancy sending a patch for that? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.k

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb added a comment. Looking at the behavior more in details. The 'bug' with a smaller screen should be fixed in kirigami instead. The focus is correct and I can move back the main category and select anoter subcategory. The problem is that Kirigami pageStack should display the page that

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb planned changes to this revision. ognarb added a comment. In D23975#532059 , @ngraham wrote: > Definitely better than before! > > One use case still doesn't work though: Returning to the first column of the sidebar when you're in the s

D23975: Improve keyboard navigation

2019-09-15 Thread Nathaniel Graham
ngraham added a comment. Definitely better than before! One use case still doesn't work though: Returning to the first column of the sidebar when you're in the second column and only a single column is visible (i.e. because the window is unmaximized). REPOSITORY R124 System Settings

D23975: Improve keyboard navigation

2019-09-15 Thread Carl Schwan
ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Since the tab view is dead, we should improve the keyboard navigation of the sidebar view TEST PLAN Played a bit with it, it looks