D23852: Show connectivity status in tooltip

This revision was automatically updated to reflect the committed changes. Closed by commit R116:695846c500d8: Show connectivity status in tooltip (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23852?vs=65807&id=

D23852: Show connectivity status in tooltip

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R116 Plasma Network Management Applet BRANCH tooltip-connectivity-status REVISION DETAIL https://phabricator.kde.org/D23852 To: jgrulich, broulik Cc: plasma-dev

D23852: Show connectivity status in tooltip

jgrulich updated this revision to Diff 65807. jgrulich added a comment. - Address review comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23852?vs=65796&id=65807 BRANCH tooltip-connectivity-status REVISION DETAIL https:

D23852: Show connectivity status in tooltip

jgrulich added a comment. In D23852#529025 , @broulik wrote: > Don't you need to connect to connectivity change signal, too? Ups, I probably want to. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricato

D23852: Show connectivity status in tooltip

broulik added inline comments. INLINE COMMENTS > networkstatus.cpp:226 > +case NetworkManager::Portal: > +status = i18n("Connected to %1 (behind captive > portal)", connection->name()); > +break; I think this is bi

D23852: Show connectivity status in tooltip

broulik added a comment. Don't you need to connect to connectivity change signal, too? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23852 To: jgrulich, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, r

D23852: Show connectivity status in tooltip

jgrulich created this revision. jgrulich added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY BUG: 411788 REPOSITORY R116 Plasma Network Management Applet BRANCH tooltip-connectivity