D23710: Introduce output replication API

2019-09-05 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R110:c8ef5444ee02: Introduce output replication API (authored by romangg). REPOSITORY R110 KScreen Library CHANGES SINCE

D23710: Introduce output replication API

2019-09-03 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in output.h:203 > Is this effectively deprecated with your changes? > > The KCM rewrite drops use of it. No, from my understanding of the backend code and the KCM code it was just handled incorrectly in the past. So before u

D23710: Introduce output replication API

2019-09-03 Thread David Edmundson
davidedmundson added a comment. At some point Generator::cloneOutput probably needs changing. INLINE COMMENTS > output.h:203 > + */ > QList clones() const; > +/** Is this effectively deprecated with your changes? The KCM rewrite drops use of it. REPOSITORY R110 K

D23710: Introduce output replication API

2019-09-03 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: KWin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY The API allows an output to be replica of another output by setting a replication source on the fo