D23386: [Applet] Double-click on icon to make it the default

2019-08-26 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Yeah, I don't disagree. Let's focus on D23389 . REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23386 To: ngraham, drosca, #plasma Cc: davidedmundson, pl

D23386: [Applet] Double-click on icon to make it the default

2019-08-26 Thread David Edmundson
davidedmundson added a comment. I don't like patches with secret features that rely on double click. We don't use double click in our UIs and we should be consistent. Also if we do have a UX problem where finding how to change the default is hard (which D23389

D23386: [Applet] Double-click on icon to make it the default

2019-08-23 Thread Nathaniel Graham
ngraham added a comment. If nobody likes this, here's an alternative: D23389: [Applet] Move "Make default" action out of the context menu and into a discoverable button REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kd

D23386: [Applet] Double-click on icon to make it the default

2019-08-23 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: drosca, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Requested in https://bugs.kde.org/show_bug.cgi?id=411065. This is hidden, but can be a n