D23378: Check if sddm user exists

This revision was automatically updated to reflect the committed changes. Closed by commit R123:85055a98133e: Check if sddm user exists (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23378?vs=66544&id=67326 REVISIO

D23378: Check if sddm user exists

filipf added a comment. Gonna land this in 24hrs if there are no objections. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sddm-user-check (branched from master) REVISION DETAIL https://phabricator.kde.org/D23378 To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt Cc: da

D23378: Check if sddm user exists

filipf added a comment. @davidedmundson is this okay now? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sddm-user-check (branched from master) REVISION DETAIL https://phabricator.kde.org/D23378 To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt Cc: davidedmundson, plasm

D23378: Check if sddm user exists

filipf updated this revision to Diff 66544. filipf added a comment. Address David's comment, remove one entry from the map REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23378?vs=65000&id=66544 BRANCH sddm-user-check (branched from

D23378: Check if sddm user exists

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. On second look, given that each one does actually do slightly different things, I rescind my request. Since this contains no new translated strings, let's land it on the 5.17 branch. REP

D23378: Check if sddm user exists

filipf added a comment. In D23378#517611 , @ngraham wrote: > How about refactoring this "does SDDM user exist?" check into a function so we don't have to write virtually the same code three times? I would need help with this. If someone c

D23378: Check if sddm user exists

filipf updated this revision to Diff 65000. filipf added a comment. Rebase on master REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23378?vs=64429&id=65000 BRANCH sddm-user-check (branched from master) REVISION DETAIL https://ph

D23378: Check if sddm user exists

davidedmundson added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:80 > // create SDDM config directory if it does not exist > QDir > sddmConfigLocation(args[QStringLiteral("sddmUserConfig")].toString()); > if (!sddmConfigLocation.exists()) { can we use sddmHomeDirPath +

D23378: Check if sddm user exists

ngraham added a comment. How about refactoring this "does SDDM user exist?" check into a function so we don't have to write virtually the same code three times? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23378 To: filipf, #plasma, davided

D23378: Check if sddm user exists

filipf updated this revision to Diff 64429. filipf added a comment. add qDebug info in auth helper REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23378?vs=64428&id=64429 BRANCH sddm-user-check (branched from master) REVISION DETAI

D23378: Check if sddm user exists

filipf updated this revision to Diff 64428. filipf edited the summary of this revision. filipf added a comment. also apply the check for the auth helper REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23378?vs=64425&id=64428 BRANCH

D23378: Check if sddm user exists

davidedmundson added a comment. Whilst client checks are nice, for the reason you're changing it this should (also?) be in the authhelper. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D23378 To: filipf Cc: davidedmundson, plasma-devel, LeGas

D23378: Check if sddm user exists

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Sddm-kcm should depend on sddm. Sddm sets up an sddm user which is used to run the greeter. Therefore it should not be possible to