MrPepe added a comment.
Weird, I actually updated my git config before comitting. Will pay attention
to it next time.
Thanks for landing it!
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D23292
To: MrPepe, #discover_software_store, ngraham
Cc: ap
ngraham added a comment.
Figured it out from your email address. :) Do please update your `.gitconfig`
file for future patches though!
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D23292
To: MrPepe, #discover_software_store, ngraham
Cc: apol, ngrah
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:7a2dc6941478: Make update page labels consistent with
topUpdateComp (authored by MrPepe, committed by ngraham).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricato
ngraham added a comment.
@MrPepe I cannot land this patch because our commit hookscript requires a
last name in addition to a first name. Can you tell me your last name and
adjust your `.gitconfig` file to include that in future patches?
Thanks!
REPOSITORY
R134 Discover Software Store
apol added a comment.
Thanks. The problem with the knsbackendtest is most likely unrelated. You can
ignore it here.
Do you have permissions to land the patch?
REPOSITORY
R134 Discover Software Store
BRANCH
consistentLabels
REVISION DETAIL
https://phabricator.kde.org/D23292
To: M
MrPepe added a comment.
This was my first contribution so I was following the wiki guide.
Running ctest showed that knsbackendtest fails. Is that a setup problem on my
side or something that actually does not work?
REPOSITORY
R134 Discover Software Store
BRANCH
consistentLabels
REVIS
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
How serindipitous; I was just about to do this myself! Needless to say, LGTM.
REPOSITORY
R134 Discover Software Store
BRANCH
consistentLabels
REVISION DETAIL
https://phabricator.kd
MrPepe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
MrPepe requested review of this revision.
REVISION SUMMARY
Made the labels on the update page consistent with the ones shown in the
topUpdateComp of the main window
TEST PLAN
Check for upda
