D23250: Try to fix i18n() timing error in version strings

2019-08-19 Thread Nathaniel Graham
ngraham updated this revision to Diff 64064. ngraham added a comment. Yeah, that seems to work too REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23250?vs=64005&id=64064 BRANCH try-to-fix-i18n-timing-error (branched from master) REVISION

D23250: Try to fix i18n() timing error in version strings

2019-08-19 Thread Aleix Pol Gonzalez
apol added a comment. Doesn't the visible addition solve it already? We can keep the i18n() call, it will fail in this case but since it's not visible it isn't a big problem anyway. @pino it's just not available in brief occasions when loading updates. REPOSITORY R134 Discover Softwar

D23250: Try to fix i18n() timing error in version strings

2019-08-18 Thread Pino Toscano
pino added a comment. This looks like a workaround to me: if `installedVersion` is not available (is it known when, actually?), why keep using it anyway, with or without i18n? Also, -1 to string puzzles and to UI strings not translatable. REPOSITORY R134 Discover Software Store REVISION

D23250: Try to fix i18n() timing error in version strings

2019-08-18 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Sometimes, `availableVersion` isn't set when the `i18n()` string is built,