This revision was automatically updated to reflect the committed changes.
Closed by commit R856:c8572d6cbed5: Let settings work with arbitrary input
controls (authored by broulik).
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23100?vs=6363
fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.
Didn't test, but looks good
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D23100
To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleig
broulik updated this revision to Diff 63638.
broulik added a comment.
- Don't write config keys for which we don't have a default
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23100?vs=63629&id=63638
REVISION DETAIL
https://phabricato
broulik updated this revision to Diff 63629.
broulik edited the summary of this revision.
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23100?vs=63567&id=63629
REVISION DETAIL
https://phabricator.kde.org/D23100
AFFECTED FILES
extension
fvogt added inline comments.
INLINE COMMENTS
> broulik wrote in options.js:119
> What do you mean?
`` -> `` and then just error out if
there's no key defined.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D23100
To: broulik, #plasma, fvogt
Cc: pla
broulik added inline comments.
INLINE COMMENTS
> fvogt wrote in options.js:119
> AFAIK we control everything on the settings page already, so why not just
> convert all of them?
What do you mean?
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D23100
fvogt added inline comments.
INLINE COMMENTS
> options.js:37
>
> function extensionCheckboxes() {
> return document.querySelectorAll("#extensions-selection
> input[type=checkbox][data-extension]");
Can be removed?
> options.js:114
> +
> +if (!settings[extension]) {
> +
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Don't limit it to just check boxes.
Check boxes will by default write into the `enabled` b
