D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
This revision was automatically updated to reflect the committed changes. Closed by commit R119:acddedf0bb1d: Use better Workspace Behavior KCM title and icon (authored by Bjrn Feber , committed by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https:/

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. Ah right. Okay, this is fine then. REPOSITORY R119 Plasma Desktop BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D22871 To: GB_2, #plasma, #vdg,

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 updated this revision to Diff 62933. GB_2 added a comment. Drop word "the" in descriptions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22871?vs=62930&id=62933 BRANCH use-better-global-workspace-behavior-kcm-title-and-icon (branched from ma

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Björn Feber
GB_2 added a comment. In D22871#505360 , @ngraham wrote: > If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in k

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Nathaniel Graham
ngraham added a comment. If we're going to make it "General", do we even need the word "Behavior" in there? It's implied by its category, no? I suppose there would be no visible parent category when running in kcmshell, but that doesn't seem like the hugest problem to me. REPOSITORY R119

D22871: Use better Workspace Behavior KCM title and icon

2019-08-01 Thread Filip Fila
filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. Looks OK, along with these two inline comments I'd also add some reasoning for the change to the commit message. INLINE COMMENTS > index.docbook:28 > > -This is a module to co