This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a8efa8653b09: Remove some uses on QDesktopWidget
(authored by apol).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22738?vs=62725&id=62857
REVISION DETAIL
apol updated this revision to Diff 62725.
apol added a comment.
Add eike's braces
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22738?vs=62582&id=62725
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22738
AFFECTED FILES
applets/
hein added inline comments.
INLINE COMMENTS
> pagermodel.cpp:123
> +};
> +for (QScreen* screen : qGuiApp->screens())
> +configureScreen(screen);
Missing braces around single-line block and no const
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D
apol updated this revision to Diff 62582.
apol added a comment.
addressed comment
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22738?vs=62534&id=62582
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22738
AFFECTED FILES
applets/
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> davidedmundson wrote in foldermodel.cpp:1640
> KNewFileMenu.cpp in the constructor
> 1148 d->m_parentWidget = qobject_cast(parent);
>
> without a transient parent we probably have focus issues?
It doesn't
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
concept ++
INLINE COMMENTS
> pagermodel.cpp:120
> +QObject::connect(qGuiApp, &QGuiApplication::screenAdded, q, [q](QScreen*
> screen) {
> +QObject::co
apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Adds an unnecessary dependency to QtWidgets and forces some round-trips to
the X server that we don't need
