This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8927e90ac08f: [SpinBox] Set renderType (authored by
broulik).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22505?vs=61898&id=61983
REV
broulik added a comment.
I want `NativeRendering` which Qt doesn't do by default. This patch is needed
either way, be it `true` or that annoying workaround. If someone with shader
knowledge could fix the native rendering shader that would be lovely, yes.
REPOSITORY
R858 Qt Quick Controls 2
apol accepted this revision.
apol added a comment.
:shrug: well sounds like a fix upstream is due, either fixing nativerendering
on non-integer scaling or just doing this everywhere.
Also if it ever gets fixed we'll stay with this workaround until someone
remembers to remove.
REPOSITORY
broulik added inline comments.
INLINE COMMENTS
> apol wrote in SpinBox.qml:69
> Should that be the case for every TextInput then? why's the SpinBox special?
It should. It was already done for `ComboBox` and `TextField` but `SpinBox` got
forgotten :)
REPOSITORY
R858 Qt Quick Controls 2: Deskt
apol added inline comments.
INLINE COMMENTS
> SpinBox.qml:69
> +// https://bugreports.qt.io/browse/QTBUG-67007
> +renderType: Screen.devicePixelRatio % 1 !== 0 ? Text.QtRendering :
> Text.NativeRendering
> +
Should that be the case for every TextInput then? why's the SpinBox spe
broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Ensures it uses the system's font rendering settings
BUG: 409888
TEST PLAN
Fonts KCM
