D22426: Add Unsplash POTD Provider

2019-07-14 Thread Filip Fila
filipf added a comment. In D22426#495465 , @ognarb wrote: > In D22426#494745 , @guoyunhe wrote: > > > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues. >

D22426: Add Unsplash POTD Provider

2019-07-14 Thread Carl Schwan
ognarb added a comment. In D22426#494745 , @guoyunhe wrote: > Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues. > > I do think it is good to show photographers' credits. But that will require change

D22426: Add Unsplash POTD Provider

2019-07-12 Thread Yunhe Guo
guoyunhe updated this revision to Diff 61678. guoyunhe added a comment. Fix Unix new line format REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22426?vs=61673&id=61678 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22426 AFFECTED FI

D22426: Add Unsplash POTD Provider

2019-07-12 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R114:e0b126692a87: Add Unsplash POTD Provider (authored by Guo Yunhe ). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22426?vs=61678&id=61679 R

D22426: Add Unsplash POTD Provider

2019-07-12 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. Works great and I don't see any problems with the code here. Let's try to avoid a ton of bikeshedding over the licenses since these are CC0 IMO. REPOSITORY R114 Plasma Addons

D22426: Add Unsplash POTD Provider

2019-07-12 Thread Yunhe Guo
guoyunhe added a comment. Photos on Unsplash are under CC0 (public domain) now. So here shouldn't be copyright issues. I do think it is good to show photographers' credits. But that will require changes to POTD class and wallpaper widget. REPOSITORY R114 Plasma Addons REVISION DETAIL

D22426: Add Unsplash POTD Provider

2019-07-12 Thread Filip Fila
filipf added a comment. Unsplash has very good wallpapers; in my opinion this automatically becomes the most attractive POTD plugin. Keep in mind though that when I tried to add Unsplash wallpapers to KDE in D18078 I was told I need to contact the au

D22426: Add Unsplash POTD Provider

2019-07-12 Thread Yunhe Guo
guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Add Unsplash Wallpaper as picture of the day provider. Unsplash provides high quality photos under public domain license. REPOSI