D22326: fix API availability/version detection to not be terribly racey

2019-07-10 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R871:e6a81b2d466b: fix API availability/version detection to not be terribly racey (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22326?vs=61514&id=61519#toc REPOSITORY R871

D22326: fix API availability/version detection to not be terribly racey

2019-07-10 Thread Harald Sitter
sitter updated this revision to Diff 61514. sitter added a comment. build fix REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22326?vs=61513&id=61514 BRANCH versioncheck REVISION DETAIL https://phabricator.kde.org/D22326 AFFECTED FILES src/CMakeList

D22326: fix API availability/version detection to not be terribly racey

2019-07-10 Thread Harald Sitter
sitter updated this revision to Diff 61513. sitter added a comment. use qprogressbar until a proper busyindicator becomes available REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22326?vs=61343&id=61513 BRANCH versioncheck REVISION DETAIL https://phab

D22326: fix API availability/version detection to not be terribly racey

2019-07-08 Thread Harald Sitter
sitter added a comment. That is rather disgusting snark there. Thanks for that REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D22326 To: sitter, #plasma Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai

D22326: fix API availability/version detection to not be terribly racey

2019-07-08 Thread Kai Uwe Broulik
broulik added a comment. I wasn't serious when I said you should use a QML view with a `BusyIndicator`. I don't think that's appropriate. You don't want DrKonqi crashing when you want to report a crash caused by the nvidia driver. Or maybe that's the plan. Clever. REPOSITORY R871 DrKonqi

D22326: fix API availability/version detection to not be terribly racey

2019-07-08 Thread Harald Sitter
sitter added a comment. Looks comme ca when the page actually is necessary: F6991301: Screenshot_20190708_171225.png F6991303: Screenshot_20190708_171054.png REPOSITORY R871 DrKonqi REVISION DETAIL h

D22326: fix API availability/version detection to not be terribly racey

2019-07-08 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously at a random point in time there'd be a call to get the bugzilla version, that call would