This revision was automatically updated to reflect the committed changes.
Closed by commit R856:cc4436cf491c: Introduce PluginManager (authored by
broulik).
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22065?vs=60997&id=61211
REVISION DET
broulik updated this revision to Diff 60997.
broulik added a comment.
- Also remove `pluginProtocolVersion`, can just call
`AbstractBrowserPlugin::protocolVersion()`
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22065?vs=60996&id=60997
broulik updated this revision to Diff 60996.
broulik added a comment.
- Operate on `AbstractBrowserPlugin *` exclusively
- Cleanup
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22065?vs=60554&id=60996
REVISION DETAIL
https://phabric
fvogt added inline comments.
INLINE COMMENTS
> pluginmanager.cpp:39
> +
> +void PluginManager::init()
> +{
Never called
> pluginmanager.cpp:69
> +
> +bool PluginManager::setPluginLoaded(const QString &subsystem, bool loaded)
> +{
I'd change this to accept the an AbstractBrowserPlugin pointer i
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This adds a dedicated class for loading/unloading and sending data to a
plugin rather than
