D22035: Port FolderView to ContainmentLayoutManager plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f3d914c0fafc: Port FolderView to ContainmentLayoutManager plugin (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22035?vs=61988&id=62269#toc REPOSITORY R119 Plasma Desktop

D22035: Port FolderView to ContainmentLayoutManager plugin

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ConfigOverlay.qml:171 > why do we do it explicitly here, but backed by a timer for movement? This is after being rotated, when changing rotation of an item the same doesn't get invoked automatically REPOSITORY R119 Plasma

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61988. mart marked an inline comment as done. mart added a comment. - remove leftovers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=61974&id=61988 BRANCH mart/newlayout REVISION DETAIL https://phabr

D22035: Port FolderView to ContainmentLayoutManager plugin

davidedmundson added inline comments. INLINE COMMENTS > ConfigOverlay.qml:171 > +//print("saving..."); > +appletsLayout.save(); > +} why do we do it explicitly here, but backed by a timer for movement? > main.qml:346 > +

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61974. mart added a comment. - use the locked editmodecondition REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=61577&id=61974 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 61577. mart added a comment. - adapt to api change - add migration script REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=60493&id=61577 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.

D22035: Port FolderView to ContainmentLayoutManager plugin

mart updated this revision to Diff 60493. mart added a comment. - remove dead code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22035?vs=60461&id=60493 BRANCH mart/newlayout REVISION DETAIL https://phabricator.kde.org/D22035 AFFECTED FILES

D22035: Port FolderView to ContainmentLayoutManager plugin

ngraham added a comment. Works perfectly with my testing on using both a pointing device and touchscreen. The touchscreen use case in particular is hugely improved. I'm not an expert on this code, but it looks pretty sane to me on read-through. INLINE COMMENTS > main.qml:322 > +/* >

D22035: Port FolderView to ContainmentLayoutManager plugin

ngraham added a comment. +1 visually! I wonder if it might make sense to make the icons on the handle bigger even in desktop mode. They're awfully small, and bigger click targets can help desktop users, too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org

D22035: Port FolderView to ContainmentLayoutManager plugin

mart added a comment. Before: F6927347: Screenshot_20190623_140805.png After: F6927342: Screenshot_20190623_140647.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22035 T