This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f59aecbcfec6: Introduce ContainmentLayoutManager QML
plugin (authored by mart).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22034?vs=61987&id=62268
REV
mart updated this revision to Diff 61987.
mart marked an inline comment as done.
mart added a comment.
- set the item container directly
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22034?vs=61976&id=61987
BRANCH
mart/containmentlayoutmanager
davidedmundson added inline comments.
INLINE COMMENTS
> configoverlay.h:67
> +private:
> +void setItemContainer(ItemContainer *container);
> +
Given ItemContainer instantiates this object (or a subclass therefore) can we
make this public and call it from ItemContainer::setConfigOverlayVisib
mart marked an inline comment as done.
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in itemcontainer.cpp:438
> If we want to use this in the panel/wherever we need ItemContainer to forward
> the full min/preferred/max sizes (with margins added) and have the
> LayoutManager
mart updated this revision to Diff 61976.
mart marked 3 inline comments as done.
mart added a comment.
- no manual parenting
- move the reaction to size hints in layoutmanager
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22034?vs=61973&id=61976
mart updated this revision to Diff 61973.
mart added a comment.
- better manage locked plasmoid logic
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22034?vs=61966&id=61973
BRANCH
mart/containmentlayoutmanager
REVISION DETAIL
https://phabrica
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in itemcontainer.cpp:370
> I may be wrong but I think if one would do
> AppletsLayout {
>
> QtObject {}
>
> }
>
> that internal object wouldn't be parented and stay dangling otherwise?
AFAIK, QML created objects don't use QO
mart updated this revision to Diff 61966.
mart marked 5 inline comments as done.
mart added a comment.
- singal when can't resize
- make resize work with items that update hints while resizing
- use setPosition and setSize where possible
- make sure to connect to busy indicator
- don't
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in abstractlayoutmanager.h:44
> I don't fully understand the split between AbstractLayoutManager and
> GridLayoutManager when AbstractLayoutManager effectively enforces a grid by
> having cell sizes.
in the end it needed cell s
davidedmundson added a comment.
Concept makes sense. I mostly like the layering and architecture, except for
all the cases where we end up searching up the hierarchy to find objects. That
doesn't seem quite as nicely layered.
I'm not finished, it's a big patch - but I thought I should su
mart updated this revision to Diff 61786.
mart added a comment.
- never auto resize while on edit mode
- try to restore size as soon as possible
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22034?vs=61642&id=61786
BRANCH
mart/containmentlayo
mart updated this revision to Diff 61642.
mart added a comment.
- manage differently screen resize and other kind of resizes
- fix snapping on RTL and BTT positioning
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22034?vs=61576&id=61642
BRANCH
mart updated this revision to Diff 61576.
mart added a comment.
- allow a limited auto expanding for applets
- click on empty areas always closes edit mode
- wire up maximum size
- start on a new logic for default sizes
- event comppress sizehints
- take minimum size into account
-
13 matches
Mail list logo
