D22005: Accept local paths

2019-10-17 Thread Méven Car
meven updated this revision to Diff 68127. meven added a comment. Use QDir::isAbsolutePath and rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22005?vs=60372&id=68127 BRANCH arcpatch-D22005 REVISION DETAIL https://phabricator.kde.org/D220

D22005: Accept local paths

2019-09-16 Thread Kai Uwe Broulik
broulik added a comment. @meven Yes, please do. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22005 To: broulik, #plasma, hein Cc: meven, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himces

D22005: Accept local paths

2019-07-26 Thread Méven Car
meven added inline comments. INLINE COMMENTS > apol wrote in actionlist.cpp:256 > if (QDir::isAbsolutePath(resource)) { > resource = QUrl::fromLocalFile(resource); > } This should be done in applets/kicker/plugin/kastatsfavoritesmodel.cpp as well line 162 and line 275. I have a patch

D22005: Accept local paths

2019-06-23 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > actionlist.cpp:256 > +if (resource.startsWith(QLatin1Char('/'))) { > +resource = QStringLiteral("file://") + resource; > +} if (QDir::isAbsolutePath(resource)) { resource = QUrl::fromLocalFile(resource); } REPOSIT

D22005: Accept local paths

2019-06-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Alternate approach to D16087 TEST PLAN 5.12 No long