D21895: print a warning when invoking the scripting API's sleep()

2019-06-24 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R120:3563f51309cc: print a warning when invoking the scripting API's sleep() (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21895?vs=60050

D21895: print a warning when invoking the scripting API's sleep()

2019-06-20 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. we could make it a no op even? REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.16 REVISION DETAIL https://phabricator.kde.org/D21895 To: sitter, mart Cc: davidedmundson, plasma-devel,

D21895: print a warning when invoking the scripting API's sleep()

2019-06-19 Thread Harald Sitter
sitter added a comment. Legacy from Plasma1 I'd guess. We could make it noop and drop it for 6.x IMO, I'm not sure if we want to change behavior halfway though 5.x though. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21895 To: sitter, mart Cc: davidedmun

D21895: print a warning when invoking the scripting API's sleep()

2019-06-19 Thread David Edmundson
davidedmundson added a comment. Why does this even exist? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21895 To: sitter, mart Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mo

D21895: print a warning when invoking the scripting API's sleep()

2019-06-19 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the sleep is implemented with a nested event loop which may result in segfaults when something in the