D21762: do not use long deprecated QString::toAscii

2019-06-24 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4cf47ad6818d: do not use long deprecated QString::toAscii (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=60564&id=60567 REV

D21762: do not use long deprecated QString::toAscii

2019-06-24 Thread Harald Sitter
sitter updated this revision to Diff 60564. sitter added a comment. and update again because arcanist hates me REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=60563&id=60564 BRANCH no-toascii REVISION DETAIL https://phabricator.kde.or

D21762: do not use long deprecated QString::toAscii

2019-06-24 Thread Harald Sitter
sitter updated this revision to Diff 60563. sitter added a comment. concat qstrings as suggested by @apol REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21762?vs=59639&id=60563 BRANCH no-toascii REVISION DETAIL https://phabricator.kde.org/D21

D21762: do not use long deprecated QString::toAscii

2019-06-12 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > waylandtasksmodel.cpp:350 > // cross-process DND. > -return QString("windowsystem/winid+" + uuid.toString().toAscii()); > +return QString("windowsystem/winid+" + uuid.toString().toLatin1()); > } It's using weird API we shouldn't be usin

D21762: do not use long deprecated QString::toAscii

2019-06-12 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY use toLatin1 instead TEST PLAN builds REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.16 REV