D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f67d61b39149: move SolidUiServer::showActionsDialog to hotplug dataengine (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21761?vs=59651&id=60785#toc REPOSITORY R120 Pla

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter updated this revision to Diff 59651. sitter added a comment. handle error conditions since we use QSP::locate we can at most have 0-1 service. in the event that we have 0 we'll set the kjob into error state and return false as result. REPOSITORY R120 Plasma Workspace CHANGES

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter added a comment. How do I correctly forward a visible error to the caller though? This ServiceJob tech is fairly beyond me. Showing a KNotification on error may be a solution, but surely there must be a better way. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabrica

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

broulik added a comment. In D21761#478528 , @sitter wrote: > I suppose it should never happen that an action cannot be resolved, so maybe an assertion to that extent is sufficient? Given device notifier only invokes it on actions it queri

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter added a comment. I am unsure about the error handling in `HotplugJob::start` I suppose it should never happen that an action cannot be resolved, so maybe an assertion to that extent is sufficient? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21761

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY it was the only remaining user of that dialog helper. the connection between the two was fairly me