D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Yeah, only certain people have commit rights. If you stick around for a while and keep submitting good patches, you can become one of those people too. :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, n

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. Can you tell me why it didn't work for me? Was it some kind of permission issue or was I doing something wrong? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, pl

D21639: Remove background from scrollbars when hovering on them

This revision was automatically updated to reflect the committed changes. Closed by commit R98:71a9a1f203df: Remove background from scrollbars when hovering on them (authored by mthw, committed by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21639?vs=59614&id=59616#toc REPOSI

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. In D21639#478268 , @mthw wrote: > I tried to land this patch but I got this error: > > fatal: remote error: service not enabled: /breeze-gtk > Usage Exception: Push failed! Fix the error and run "arc land" again.

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. I tried to land this patch but I got this error: fatal: remote error: service not enabled: /breeze-gtk Usage Exception: Push failed! Fix the error and run "arc land" again. Could you help me with this? > Very nice first patch. May it be the first of ma

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Very nice first patch. May it be the first of many! If you'd like an idea for a follow-up patch, here's an idea: make the handles of the non-disappearing scrollbars gray instead blue when unhovered, and make the track only appear on hover, matching the ones in Firefo

D21639: Remove background from scrollbars when hovering on them

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, looks perfect now! REPOSITORY R98 Breeze for Gtk BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL https://phabricator.kde.org/D21639 To: mt

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59614. mthw added a comment. Formating REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59613&id=59614 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL https://phabricator

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59613. mthw added a comment. Sliders are now grey, and when hovered blue and bigger. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59383&id=59613 BRANCH breeze-gtk-scrollbar-no-background (branched from

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. I think I see the problem. By making the default color turquoise, the scrollbar is now always turquoise. If we can't perfectly match the Dolphin/QWidgets style where it's gray when inactive and turquoise when active, hovered, or clicked, I think we should leave it gr

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. > Firefox's scrollbar still does not have the correct appearance... Do you mean Firefox having blue scroollbar now, instead of grey it had before? Is that a real problem? I mean, couldn't it stay like this? The problem roots from default color now being blue instead

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Thanks! However Firefox's scrollbar still does not have the correct appearance when not hovered; compare it to GIMP or Inkscape. This is a regression from the status quo. Everything else looks good to me now, but that regression needs to be fixed before we can land t

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. @ngraham Can you please review this? It's as good as I can make it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh,

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59383. mthw added a comment. There are lines that 'git diff' says are different altough shows them exactly the same and I don't know what to do with that. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=5938

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59382. mthw added a comment. Hopefully the final version REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59364&id=59382 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL h

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#476035 , @ngraham wrote: > In D21639#476019 , @mthw wrote: > > > I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow.

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. In D21639#476019 , @mthw wrote: > I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow. The different behaviors are actually fairly subtle. This is what's typical f

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. I changed the color to always blue so it looked more like Dolphin. But I can change it back tomorrow. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, plasma-devel

D21639: Remove background from scrollbars when hovering on them

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Nope sorry, found an issue. :) Now the non-disappearing scrollbars in Firefox are always turquoise rather than normally being gray and turning turquoise when hovered. Also,

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. In D21639#475983 , @mthw wrote: > Is there an easy way to find all spots that need editing? In your branch, run `git show HEAD` I see that the original formatting of the file is totally messed up though. :/ D

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59364. mthw added a comment. Few more changes REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59362&id=59364 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETAIL https://phab

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59362. mthw added a comment. I tried to make some changes but I doubt I caught all problems. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59352&id=59362 BRANCH breeze-gtk-scrollbar-no-background (branch

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. Is there an easy way to find all spots that need editing? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filipf, ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragr

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. So sorry to hear about the disappearing scrollbar issue being something you can's fix in the theme. Pity. Not totally unexpected though. This is much better, thanks! There are still a few ordinary whitespace and formatting issues, e.g.: F6876658: Screenshot_

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. About that scrollbar hiding, after some googling it looks like it's a known problem in GTK+. It would seem that it cannot be changed by a theme or otherwise. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze,

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59352. mthw added a comment. An attempt to fix the number of lines. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59350&id=59352 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Very close! The track and hover behavior now look perfect. But the handle still disappears entirely when the mouse is outside of the scrollview. Dolphin doesn't do that. Also `src/gtk320/widgets/_scrollbar.scss` still has the wrong line endings. You can see how

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59350. mthw added a comment. Scrollbars now should work exactly like in Dolphin, please review. Hope there are no problems with the file like last time. Everything looks fine here. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabrica

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475884 , @filipf wrote: > You can also turn on the option to show trailing whitespace in Kate: > > F6876354: image.png I have set this and everything looks fine, I

D21639: Remove background from scrollbars when hovering on them

filipf added a comment. You can also turn on the option to show trailing whitespace in Kate: F6876354: image.png REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: filip

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. If you want to make the scrollbar behavior here mimic Dolphin, that would be great. That means: - A thin version of the scrollbar handle is always visible - When the scrollbar is hovered over, it gets fatter and its background track becomes visible - The back

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475864 , @ngraham wrote: > Ah, this change only affects those horrible scrollbars that disappear when not being used and leave you unable to see at a glance what position you're at in the view or even that the vie

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Ah, this change only affects those horrible scrollbars that disappear when not being used and leave you unable to see at a glance what position you're at in the view or even that the view is scrollable in the first place. This change seems to work fine and improves t

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475858 , @ngraham wrote: > I didn't notice any difference with Firefox or GIMP. What app should I use to test this? GTK3-demo or pamac-manager, Firefox doesn't seem to be affected by this. And for Gtk 3.18

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. I didn't notice any difference with Firefox or GIMP. What app should I use to test this? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: ngraham, ndavis, plasma-devel, LeGast00n, erica

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. Another question is whether we don't want to keep the scrollbar background after all. That would make it look exactly like in Dolphin/Qt. See: https://imgur.com/a/2EeF7pp . The problem is I don't seem to be able to fix the horizontal scrollbar, see: https://imgur.com/a/

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59336. mthw added a comment. Made changes to Gtk 3.18 hopefully they work REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59324&id=59336 BRANCH breeze-gtk-scrollbar-no-background (branched from master) RE

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. I made that change, but I don't know if it works. I don't know a way to test it. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jrale

D21639: Remove background from scrollbars when hovering on them

ngraham added a comment. Ugh, yes I do mean that! :) REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, ndavis, ngraham Cc: ngraham, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesl

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475790 , @ngraham wrote: > `src/gtk/widgets/_scrollbar.scss` needs the same change as well. Do you mean 'src/gtk318/widgets/_scrollbar.scss'? There is no 'src/gtk/widgets/_scrollbar.scss' REPOSITORY R98

D21639: Remove background from scrollbars when hovering on them

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. `src/gtk/widgets/_scrollbar.scss` needs the same change as well. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D21639 To: mthw, #vdg, #breeze, n

D21639: Remove background from scrollbars when hovering on them

ndavis accepted this revision as: VDG, ndavis. ndavis added a comment. This revision is now accepted and ready to land. In D21639#475696 , @mthw wrote: > In D21639#475649 , @ndavis wrote: > > > This s

D21639: Remove background from scrollbars when hovering on them

mthw updated this revision to Diff 59324. mthw added a comment. None is not a valid color warning REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21639?vs=59317&id=59324 BRANCH breeze-gtk-scrollbar-no-background (branched from master) REVISION DETA

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. In D21639#475649 , @ndavis wrote: > This seems inconsistent with our Qt Widget scrollbars... Do you mean by this, that there should be a "rail" behind the scrollbar? Or what else seems to be the problem? REPOSITORY

D21639: Remove background from scrollbars when hovering on them

mthw added a comment. The original idea was to make the scrollbar look more like in Dolphin and other Qt apps. I tested this with gtk3-demo, pamac-manager and Firefox. Everything works correctly and Firefox doesn't seem to be affected at all. Also Breeze dark doesn't seem to be affected/chan

D21639: Remove background from scrollbars when hovering on them

ndavis added a comment. This seems inconsistent with our Qt Widget scrollbars. Is there no chance that the scrollbar would be hard to see against some backgrounds? What GTK themed apps did you test with? How does it affect Firefox? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://p