D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-06-09 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R116:871fd3dfe3e1: Don't keep a full NetworkModel instance alive when it's not visible (authored by apol). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator

D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-05-30 Thread Jan Grulich
jgrulich added a comment. Doesn't seem to have any impact on performance. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D21501 To: apol, #plasma, jgrulich Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, h

D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-05-30 Thread Aleix Pol Gonzalez
apol added a comment. Trying it locally I don't have the feeling that it's slower, networkmanager has the information internally after all. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D21501 To: apol, #plasma, jgrulich Cc: ngraham, plasma

D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-05-30 Thread Nathaniel Graham
ngraham added a comment. Will this delay the full representation's ability to quickly display the network list when opened? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D21501 To: apol, #plasma, jgrulich Cc: ngraham, plasma-devel, jraleigh

D21501: Don't keep a full NetworkModel instance alive when it's not visible

2019-05-30 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. apol requested review of this revision. REVISION SUMMARY This was implemented as an optimisation in Plasma a