D21274: Don't assign a QtObject to a model

2019-05-21 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:a282bc9d612a: Don't assign a QtObject to a model (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21274?vs=58261&id=58450#toc REPOSITORY R120 Plasma Workspace CH

D21274: Don't assign a QtObject to a model

2019-05-21 Thread Fabian Vogt
fvogt added a comment. Yes, but the workaround here has no actual downsides, and the upside is avoiding a guaranteed crash with the still latest non-development release of Qt. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21274 To: davide

D21274: Don't assign a QtObject to a model

2019-05-21 Thread David Edmundson
davidedmundson added a comment. FWIW, the relevant Qt bug is fixed. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21274 To: davidedmundson, #plasma, fvogt Cc: fvogt, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, l

D21274: Don't assign a QtObject to a model

2019-05-21 Thread Fabian Vogt
fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested on top of the 5.16 beta, works fine. Please add a comment referencing the QTBUG though, so that this doesn't get reintroduced by accident. REPOSITORY R120 Plasma Workspace BRANCH

D21274: Don't assign a QtObject to a model

2019-05-20 Thread David Edmundson
davidedmundson added a comment. That would still hit the Qt crash unless I declare all used properties, which is the part I wanted to avoid. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21274 To: davidedmundson, #plasma Cc: apol, plasma-devel, jraleigh,

D21274: Don't assign a QtObject to a model

2019-05-18 Thread Aleix Pol Gonzalez
apol added a comment. To do this in the past I've used an object array which would read a bit less hacky. userListModel: [ QtObject { /*...*/} ] REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21274 To: davidedmundson, #plasma Cc: apol, plasma-devel,

D21274: Don't assign a QtObject to a model

2019-05-18 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's a weird thing to do, and that's causing us to hit https://bugreports.q