D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:6d0289d7b284: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1 (authored by filipf). REPOSITOR

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf added a comment. So I looked up Google's documentation and it turns out sliders do have to be mirrored: https://material.io/design/usability/bidirectionality.html#mirroring-elements https://material.io/design/components/sliders.html#usage As for the implementation, @broulik men

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf updated this revision to Diff 57752. filipf added a comment. fix handle behavior for right to left layouts REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21075?vs=57738&id=57752 BRANCH fix-qqc2-slider-when-from-is-1 (bra

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf added a comment. In D21075#462419 , @broulik wrote: > Hm, right, seems the slider behaves incorrectly without this patch, too :/ Still I think `visualPosition` is what we want to be using About Qt's unmodified slider, isn't that on

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

broulik added a comment. Hm, right, seems the slider behaves incorrectly without this patch, too :/ Still I think `visualPosition` is what we want to be using REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D21075 To: filipf, mart, #plasma,

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf added a comment. In D21075#462393 , @broulik wrote: > -1 > This breaks the slider in right-to-left mode. Run `qmlscene -reverse` to see Hmm seems to be behaving the same as before, just that the handle is now on the tickmark.

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

broulik added a comment. -1 This breaks the slider in right-to-left mode. Run `qmlscene -reverse` to see REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fix-qqc2-slider-when-from-is-1 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21075 To: filipf, mar

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. @mart, does this look like the right fix? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fix-qqc2-slider-when-from-is-1 (branched from master) REVISION DET

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Old code was not reading value properly when initial value was 1, misplacing the handle as a result. BUG: 405471 REPOSITORY R