D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-06 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R120:1f37ba3b81f2: [PanelView] remove outdated hack to support mask without compositing (authored by kossebau). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2

D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D21013#460774 , @mvourlakos wrote: > > This really needs a proper solution with well defined concepts. > > yep, I agree... > > This is why I left the assumption only in one place and I didnt merge more commit

D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-04 Thread Michail Vourlakos
mvourlakos added a comment. In D21013#460765 , @kossebau wrote: > Eek, sorry for breaking things. Will have some thoughts about it. > Though, hm, `item->window()->mask().isNull()` is really a random heuristic asking to break sooner or later,

D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. Eek, sorry for breaking things. Will have some thoughts about it. Though, hm, `item->window()->mask().isNull()` is really a random heuristic asking to break sooner or later, given we have seen all kind of panel/dock styles by the time :) Well, actually it was alr

D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-04 Thread Michail Vourlakos
mvourlakos added a subscriber: davidedmundson. mvourlakos added a comment. In D21013#460745 , @kossebau wrote: > In D21013#460743 , @mvourlakos wrote: > > > @kossebau one information please, with thi

D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D21013#460743 , @mvourlakos wrote: > @kossebau one information please, with this set of paches the svg mask is also applied and in COMPOSITING state for the panels? Yes. As in: at least most of the time as th

D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-04 Thread Michail Vourlakos
mvourlakos added a comment. @kossebau one information please, with this set of paches the svg mask is also applied and in COMPOSITING state for the panels? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21013 To: kossebau, #plasma Cc: mvourlakos, plasma-de

D21013: [PanelView] remove outdated hack to support mask without compositing

2019-05-04 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY The actual mask is now queried from the panel, there is no more need for this. REPOSITORY