D20933: Increase buffer for cpuinfo

2019-05-01 Thread Christoph Feck
cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. And indeed I didn't mark the bug as a junior job, because incremental parsing the info isn't exactly a quick fix. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.

D20933: Increase buffer for cpuinfo

2019-05-01 Thread Christoph Feck
cfeck added a comment. The info for each CPU is indeed a bit larger than 1K. Using 64KiB will only be sufficient for 32 CPUs, the rest would be wasted. As the comment indicates, Linux supports up to 4096 CPUs, so the buffer should be much bigger, or (ideally) the code refactored to do increm

D20933: Increase buffer for cpuinfo

2019-05-01 Thread Pino Toscano
pino added a comment. I don't think that 1024 represents anything here, just the factor to get kibibytes. So just bump the first value to 64, or even 128. What's the size of `/proc/cpuinfo` on your system? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D2093

D20933: Increase buffer for cpuinfo

2019-05-01 Thread Tilman Klaeger
tilmank created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tilmank requested review of this revision. REVISION SUMMARY With increasing number of flags and also bug tags in cpuinfo (sepctre, meltdown, …) the size increases and with 32 cores it´s to sm