This revision was automatically updated to reflect the committed changes.
Closed by commit R116:257b03b185d3: Reject invalid keys (authored by McPain).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20900?vs=57249&id=57266
REVISION DET
McPain updated this revision to Diff 57249.
McPain marked an inline comment as done.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20900?vs=57245&id=57249
BRANCH
D20900
REVISION DETAIL
https://phabricator.kde.org/D20900
AFFECTED
jgrulich added inline comments.
INLINE COMMENTS
> passworddialog.cpp:76
> +
> m_connectionSettings->setting(NetworkManager::Setting::WirelessSecurity).staticCast();
> +if (m_connectionSettings->connectionType() ==
> NetworkManager::ConnectionSettings::Wireless
> +
McPain updated this revision to Diff 57245.
McPain edited the summary of this revision.
McPain removed 1 blocking reviewer(s): jgrulich.
Herald added 1 blocking reviewer(s): jgrulich.
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20900
jgrulich added inline comments.
INLINE COMMENTS
> passworddialog.cpp:93
> +if (!valid) {
> +
> m_ui->buttonBox->setStandardButtons(QDialogButtonBox::Cancel);
> +} else {
It shouldn't definitely be hiding buttons, you can make the "OK" button just
disabled
McPain updated this revision to Diff 57239.
McPain retitled this revision from "Reject short PSK passwords" to "Reject
invalid keys".
McPain edited the summary of this revision.
McPain added a comment.
validate WPA-PSK and WEP keys
REPOSITORY
R116 Plasma Network Management Applet
CHANGES S
