D20564: Change default user avatar

2019-04-20 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > Ping For future, the commit message is important. The person reviewing doesn't have the same context you have when you're making the change, if you can

D20564: Change default user avatar

2019-04-20 Thread Björn Feber
GB_2 added a comment. Ping REPOSITORY R128 User Manager BRANCH change-default-user-avatar (branched from master) REVISION DETAIL https://phabricator.kde.org/D20564 To: GB_2, #plasma, #vdg, ngraham, afiestas, broulik Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pi

D20564: Change default user avatar

2019-04-14 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works and makes sense to me, but I'm not as familiar with the `user-manager` codbease and would appreciate a #plasma review too, in case thi

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 updated this revision to Diff 56265. GB_2 added a comment. Remove monochrome icon REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20564?vs=56264&id=56265 BRANCH change-default-user-avatar (branched from master) REVISION DETAIL https://phabric

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 added a comment. Ok, the problem is that now the default user icon doesn't work with a dark theme. I think we should just provide it in `breeze-icons`, so it is the default user icon that also gets selected when you click `Clear Avatar`. REPOSITORY R128 User Manager REVISION DETAIL

D20564: Change default user avatar

2019-04-14 Thread Björn Feber
GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Needed for D20536 TEST PLAN Open the avatar gallery. REPOSITOR