D20418: Support custom icon size for ToolButton

2019-04-11 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R858:d9024903e297: Support custom icon size for ToolButton (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20418?vs=5585

D20418: Support custom icon size for ToolButton

2019-04-09 Thread Kai Uwe Broulik
broulik added a subscriber: laysrodrigues. broulik added a comment. @laysrodrigues asked for it. I don't think there's a usecase for a "proper" desktop app, but having an API in Qt that we then silently ignored is bad, especially since it works fine with a regular `Button` REPOSITORY R858

D20418: Support custom icon size for ToolButton

2019-04-09 Thread Nathaniel Graham
ngraham added a comment. What's the use case, out of curiosity? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D20418 To: broulik, #plasma, mart, apol Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-moha

D20418: Support custom icon size for ToolButton

2019-04-09 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Copied from `PushButton` ToolButton { icon.width: 128 icon.height: 128