D20249: Make the Configuration button more understandable

2019-04-06 Thread Michail Vourlakos
mvourlakos added a comment. Following the comments I have updated a bit the Rearrange button, these are some results with the new approach: normal: F6756477: image.png hovered: F6756481: image.png

D20249: Make the Configuration button more understandable

2019-04-05 Thread Filip Fila
filipf added a comment. Hey @trmdi rooty's not participating in KDE at this point so he won't be able to do the review. Just so I don't stop by without giving a contribution: I like the idea of making it more obvious that it's a button. Maybe you could reach a compromise here and have t

D20249: Make the Configuration button more understandable

2019-04-05 Thread Michail Vourlakos
mvourlakos added inline comments. INLINE COMMENTS > HeaderSettings.qml:87 > +textColor: colorizerManager.buttonTextColor > +backgroundColor: containsMouse? colorizerManager.buttonHoverColor : > colorizerManager.buttonBackgroundColor > checkedTextColor: colorizerManager.h

D20249: Make the Configuration button more understandable

2019-04-05 Thread Tranter Madi
trmdi updated this revision to Diff 55472. trmdi added a comment. Set hoverColor REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20249?vs=55412&id=55472 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20249 AFFECTED FILES containment/p

D20249: Make the Configuration button more understandable

2019-04-04 Thread Michail Vourlakos
mvourlakos added a comment. he will be educated to do so REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20249 To: trmdi, #latte_dock, rooty, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D20249: Make the Configuration button more understandable

2019-04-04 Thread Tranter Madi
trmdi added a comment. In D20249#443373 , @mvourlakos wrote: > I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered How would the user know it's a button to hover it? He's unlike

D20249: Make the Configuration button more understandable

2019-04-04 Thread Michail Vourlakos
mvourlakos added a comment. I am not sure... I think would prefer a hovering mechanism, a rectangle with transparency e.g. 0.5 when this option is hovered REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20249 To: trmdi, #latte_dock, rooty, mvourlakos Cc: mvourl

D20249: Make the Configuration button more understandable

2019-04-04 Thread Michail Vourlakos
mvourlakos added a comment. screenshots please REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D20249 To: trmdi, #latte_dock, rooty Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D20249: Make the Configuration button more understandable

2019-04-04 Thread Tranter Madi
trmdi created this revision. trmdi added reviewers: Latte Dock, rooty. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Without the button background, it's difficult to realize that it's a button. REPOSITORY R87