apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Looks good!
REPOSITORY
R871 DrKonqi
BRANCH
webservice
REVISION DETAIL
https://phabricator.kde.org/D19612
To: sitter, apol
Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2
sitter updated this revision to Diff 60061.
sitter added a comment.
cleanup try 3
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19612?vs=60060&id=60061
BRANCH
webservice
REVISION DETAIL
https://phabricator.kde.org/D19612
AFFECTED FILES
CMakeLists.
sitter updated this revision to Diff 60060.
sitter added a comment.
diff cleanup try 2
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19612?vs=60059&id=60060
BRANCH
webservice
REVISION DETAIL
https://phabricator.kde.org/D19612
AFFECTED FILES
CMakeL
sitter updated this revision to Diff 60059.
sitter added a comment.
clean up diff maybe?
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19612?vs=60058&id=60059
BRANCH
webservice
REVISION DETAIL
https://phabricator.kde.org/D19612
AFFECTED FILES
CMak
sitter updated this revision to Diff 60058.
sitter added a comment.
- refactor
- move clients to subdir
- catch all exceptions
- don't incorrectly init the static
- cleanup includes
- more tests and less asserts
- litter--
- split commands
- throw out a whole bunch of warnings a
sitter updated this revision to Diff 53953.
sitter added a comment.
competing api design on commentsclient::getfrombug2
this has some more cruft but looks nicer from a usage POV IMO
it's basically lambda chaining originating in a signal...
instead of return a kjob the getter returns
sitter updated this revision to Diff 53889.
sitter added a comment.
redo diff so it maybe doesn't include nonesense
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19612?vs=53888&id=53889
BRANCH
webservice
REVISION DETAIL
https://phabricator.kde.org/D1
sitter updated this revision to Diff 53888.
sitter added a comment.
search now searches long description so only get somewhat pertinent bugs come
back as results. also implement pagniation of results (ie. only 25 results at a
time are queried, this is both much faster to query and to parse).
sitter updated this revision to Diff 53669.
sitter added a comment.
- repair dupe detection - was running on empty list
- refactor bug fetching to not include comment fetching and port all users of
it
- stop holding all comments of all bugs in memory. we have no use for like
99% of them a
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
I'd love some feedback on the lib api especially. this is the first REST
wrapper I wrote using cpp, so it feels all a bit clunky to
10 matches
Mail list logo