D19203: ColumnView and partial C++ refactor of PageRow

2019-02-28 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:c0f2a341a4c9: ColumnView and partial C++ refactor of PageRow (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19203?vs=52799&id=52803 REVISION D

D19203: ColumnView and partial C++ refactor of PageRow

2019-02-28 Thread Nicolas Fella
nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Works fine with KDE Connect REPOSITORY R169 Kirigami BRANCH mart/columnsView REVISION DETAIL https://phabricator.kde.org/D19203 To: mart, #kirigami, nicolasfella Cc: nic

D19203: ColumnView and partial C++ refactor of PageRow

2019-02-28 Thread Marco Martin
mart updated this revision to Diff 52799. mart added a comment. - a bit more drag distance to be sure not to conflict with horizontal - preventStealing attached property - hide items when removed - fix item position mapping - signal the visible items when forgetting one - update curre

D19203: ColumnView and partial C++ refactor of PageRow

2019-02-21 Thread Marco Martin
mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY ColumnView is a container component which encapsulates most of the logic from PageRow (minus the ins