apol added inline comments.
INLINE COMMENTS
> powerdevilapp.cpp:69
> + i18nc("@info:credit", "(c) 2015-2019 Kai Uwe
> Broulik"));
> +aboutData.addAuthor(i18nc("@info:credit", "Kai Uwe Broulik"),
> +i18nc("@info:credit", "Maintainer"),
PRobably
This revision was automatically updated to reflect the committed changes.
Closed by commit R122:972eb26d0558: Add KAboutData (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19162?vs=52077&id=52083#toc
REPOSITORY
R122 Powerdevil
CHANGES SINCE LAST UPDATE
https://
ngraham added inline comments.
INLINE COMMENTS
> powerdevilapp.cpp:69
> + i18nc("@info:credit", "(c) 2015-2019 Kai Uwe
> Broulik"));
> +aboutData.addAuthor(i18nc("@info:credit", "Kai Uwe Broulik Angelaccio"),
> +i18nc("@info:credit", "Maintaine
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
LGTM
And FWIW I agree that following PROJECT_VERSION would be nicer.
REPOSITORY
R122 Powerdevil
REVISION DETAIL
https://phabricator.kde.org/D19162
To: broulik, #plasma, sitter
Cc:
broulik created this revision.
broulik added reviewers: Plasma, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Ensures correct app info is set, for example when crashing
TEST PLAN
send a SIGSEGV, now
