D19014: [plasma-pa] Add command to switch all applications to the selected device

This revision was automatically updated to reflect the committed changes. Closed by commit R115:61259acda87b: [plasma-pa] Add command to switch all applications to the selected device (authored by vpilo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricato

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. Excellent. Sorry I had no time to follow up for the icon creation yet. REPOSITORY R115 Plasma Audio Volume Applet BRANCH vpilo/switchStreamsToDevice (branched from master) REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca, #v

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, let's get it in even if we don't have a new icon quite yet. That can be added via a frameworks update anyway. REPOSITORY R115 Plasma Audio Volume Applet BRANCH vpilo/switchStream

D19014: [plasma-pa] Add command to switch all applications to the selected device

filipf added a comment. Ping, would be nice to have in 5.16. If there's an issue with getting an icon made, it would be okay I think to have a generic one and then fix it later. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #pla

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added a comment. Sounds good to me! REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca, #vdg Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. In D19014#417976 , @ngraham wrote: > In D19014#417906 , @vpilo wrote: > > > @ngraham If a new icon should be made, who could do it and how does the request process go? > >

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added a comment. In D19014#417906 , @vpilo wrote: > @ngraham If a new icon should be made, who could do it and how does the request process go? #VDG can hook you up. File a bug in Breeze | I

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. @ngraham If a new icon should be made, who could do it and how does the request process go? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca, #vdg Cc: ngraham, plasma-devel, jraleigh,

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:315 > Of those, I'd say `audio-ready` seems least inappropriate, but It almost > seems like we need a new icon that uses the speaker symbol with an arrow > somewhere in it to connote movement and change. I hoped I co

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added inline comments. INLINE COMMENTS > vpilo wrote in ListItemBase.qml:315 > All three options for icons are for me ok, what about #vdg > ? Of those, I'd say `audio-ready` seems least inappropriate, but It almost seems like we need a new icon th

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a reviewer: VDG. vpilo added inline comments. INLINE COMMENTS > ListItemBase.qml:315 > +menuItem.text = i18n("Play all audio via this device"); > +menuItem.icon = "audio-on" // or "audio-ready" // or > "audio-speakers-symbolic" > +menuI

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo updated this revision to Diff 52146. vpilo added a comment. - Review comments - Add icons REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19014?vs=51895&id=52146 BRANCH vpilo/switchStreamsToDevice (branched from master) REVISIO

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo updated this revision to Diff 51895. vpilo added a comment. - Review comments REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19014?vs=51699&id=51895 BRANCH vpilo/switchStreamsToDevice (branched from master) REVISION DETAIL htt

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added inline comments. INLINE COMMENTS > ngraham wrote in ListItemBase.qml:306 > How about "Play all audio using this device" Better already; I'm also concerned whether the label should become too long. Let's see what happens. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added inline comments. INLINE COMMENTS > ListItemBase.qml:306 > +menuItem = newMenuItem(); > +menuItem.text = i18n("Switch all applications here"); > +menuItem.clicked.connect(function() { How about "Play all audio using this device" REPOS

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo added a comment. I would love some input about: - The wording of the menu entry. - The possibility of having an icon for the menu entry. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca Cc: ngra

D19014: [plasma-pa] Add command to switch all applications to the selected device

ngraham added a comment. +1, a very nice feature. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D19014 To: vpilo, #plasma, broulik, drosca Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D19014: [plasma-pa] Add command to switch all applications to the selected device

vpilo created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vpilo requested review of this revision. REVISION SUMMARY If you have many applications running (e.g. browser tabs) it's very annoying to manually switch them all to another device. With this c