This revision was automatically updated to reflect the committed changes.
Closed by commit R119:67d8ac416ff6: Use Dialog's visibility directly
rather than relying on the mainItem's (authored by broulik).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18
davidedmundson added a comment.
That framework change is released tomorrow, right? Is it worth reverting?
Including this, that's at least the second regression it's caused, which
makes me worry there's even more we haven't found.
> It should have used Dialog's visiblity from the begin
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
Works. No side effects.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D18844
To: broulik, #plasma, lbeltrame
Cc: lbeltrame, plasma-devel, jraleigh, G
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
`Dialog` no longer alters the `mainItem`'s visiblity, so this codepath failed.
It should have us
