D18802: Fix pragma once problem with process class

This revision was automatically updated to reflect the committed changes. Closed by commit R871:e01d73c3c3be: Fix pragma once problem with process class (authored by patrickelectric). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18802?vs=51257&id=51358#toc REPOSITORY R871 DrKonqi CH

D18802: Fix pragma once problem with process class

patrickelectric added a comment. https://stackoverflow.com/questions/17107410/qt-field-has-incomplete-type REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2

D18802: Fix pragma once problem with process class

davidedmundson added a comment. But if this works...meh, go for it. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18802: Fix pragma once problem with process class

davidedmundson added a comment. Your comment doesn't match what the internet says about "#pragma once" (though it is a non-standard and some compilers are weird) Two files with the same filename should be included twice. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.o

D18802: Fix pragma once problem with process class

patrickelectric added a comment. In D18802#408691 , @davidedmundson wrote: > > @mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :) > > It hasn't updated what phab shows

D18802: Fix pragma once problem with process class

davidedmundson added a comment. > @mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :) It hasn't updated what phab shows. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickel

D18802: Fix pragma once problem with process class

patrickelectric added a comment. Also, this PR is really important to help Craft since the patch command used to apply .diffs/patchs can't move/rename files. This patch needs to be added manually to do the build. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D188

D18802: Fix pragma once problem with process class

patrickelectric added a comment. @mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :) REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngrah

D18802: Fix pragma once problem with process class

patrickelectric updated this revision to Diff 51257. patrickelectric added a comment. Update commit message REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18802?vs=51068&id=51257 BRANCH arcpatch-D18802 REVISION DETAIL https://phabricator.kde.org/D1880

D18802: Fix pragma once problem with process class

alexeymin added a comment. Is it because process.h exists somewhere else? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesli

D18802: Fix pragma once problem with process class

mart added a comment. needs better commit message REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18802: Fix pragma once problem with process class

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH fix_pragma REVISION DETAIL https://phab