This revision was automatically updated to reflect the committed changes.
leinir marked an inline comment as done.
Closed by commit R134:003fc9fc9800: Add a timeout for KNS backends (authored by
leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D18724?vs=50845&id=50950#toc
REPOSITOR
leinir marked an inline comment as done.
leinir added inline comments.
INLINE COMMENTS
> davidedmundson wrote in KNSBackend.cpp:143
> this already calls setFetching(false).
Good spot, i'll just swipe that and get it in :)
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phab
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> KNSBackend.cpp:143
> +if(!m_initialized) {
> +markInvalid(i18n("Backend %1 took too long to initialize",
> m_displayName));
> +
leinir created this revision.
leinir added reviewers: ngraham, apol, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.
REVISION SUMMARY
This patch will mark
