D18716: Add a SearchField component

ognarb updated this revision to Diff 51215. ognarb added a comment. Create a generic TextField instead REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=50813&id=51215 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18716 AFFECTED F

D18716: Add a SearchField component

mart added a comment. In D18716#404852 , @ognarb wrote: > Interesting, but I have some question before I start implementing. > > - Do you have an example for a left action? right now only web browsers url bars come to mind, so perhaps

D18716: Add a SearchField component

ngraham added a comment. I agree, it should be a generic TextField that just so happens to be useful as a search field if you'd like. Bonus points if one of the built-in actions is "show/hide password" so it can be used as a password field too. REPOSITORY R169 Kirigami REVISION DETAIL h

D18716: Add a SearchField component

broulik added a comment. > Should the buttons only be visible when the text is not empty? Or can this behavior also be configurable with a property? `Action` has a `visible` property which should be taken into account like normal here as well REPOSITORY R169 Kirigami REVISION DETAIL

D18716: Add a SearchField component

ognarb added a comment. In D18716#404718 , @mart wrote: > If we are going to have a specialized line edit, I think it shouldn't be specific for search, but be a common component of things that we have to boilerplate too often as they are missing

D18716: Add a SearchField component

apol added a comment. I'm fine with having this code relicensed. INLINE COMMENTS > ngraham wrote in SearchField.qml:33 > @apol Is this still applicable if it's a re-usable component? No, this is for Discover-specific behavior. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricato

D18716: Add a SearchField component

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. If we are going to have a specialized line edit, I think it shouldn't be specific for search, but be a common component of things that we have to boilerplate too often as they are mis

D18716: Add a SearchField component

ngraham added a comment. Nice, I give my permission for the re-licensing. INLINE COMMENTS > SearchField.qml:33 > +id: searchField > +property QtObject page > +property string currentSearchText @apol Is this still applicable if it's a re-usable component? REPOSITORY R169 Kiriga

D18716: Add a SearchField component

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY This is based on the searchField from Discover. It's a sugestion from @ngraham and I find it's a great idea. Note: Because it'